feat(web): extract i18n messages for map, people, media, upload and sharing surfaces (wave 3) #1186
Loading…
Reference in a new issue
No description provided.
Delete branch "feature/i18n-extraction-wave3"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Wave 3 of the Paraglide v2 i18n extraction: the
map,people,person,placesroute bodies,MediaDetailViewer+media/**components, upload surfaces and sharing surfaces.apps/web/messages/{en,de,da}.json(each locale now has 1,640 keys). The block is contiguous and prefix-grouped, appended after the wave-4 block; all pre-existing keys are byte-identical (verified programmatically: upstream key order + values unchanged, key sets identical across the three locales).m.*call sites wired across 24 source files, including attributes (aria-label/title/placeholder/alt).albumReject,instanceDetailDone,albumBadgeAdd,setupReady,setupNeedsAttention) — no duplicate values introduced.Intl.*calls in touched files usegetLocale()(verified: no hardcoded locale tags remain in scope).mediaResetAllDone(8 arms).MediaDetailViewer'scloseLabelprop is now explicitly typedstring(the localized default had Svelte infer the brandedLocalizedString, which broke literal call sites outside this wave — albums, processing-issues, profile, … — those files were intentionally not touched).Sites per file
media/MediaInfoPanel.svelteContributionPanel.svelteroutes/uploads/+page.svelteroutes/sharing/+page.sveltemedia/MediaViewer.sveltemedia/MediaDiscoverySection.svelteMediaDetailViewer.sveltemedia/EditMarkerLabelDialog.sveltemedia/mediaUtils.tsroutes/map/+page.sveltePersonTargetPicker.sveltemedia/FaceMarkerEditToolbar.sveltemedia/RerunDiscoveryDialog.svelteroutes/places/+page.svelteMapView.svelte,ShareTargetAutocomplete.sveltemedia/EditModeActions.svelte,media/DiscoveryEditModeOverlay.sveltemedia/FaceMarkerOverlay.sveltemedia/DomainToggleBar.svelte,media/DiscoveryEditToggle.svelteroutes/people/+page.svelte,routes/person/[personId]/+page.svelte,media/EditModeBanner.svelteE2E decisions (message values unchanged — expectations updated)
English expectation (specs mixed English and Danish assertions; app default locale is
en):domain-toggle-bar,face-marker-visibility,plant-overlay-markers:Toggle Planter markers→Toggle Plants markers,Toggle Personer markers→Toggle People markers(labels now come frommediaUtilsDomainPlants/mediaUtilsDomainPeople).edit-nav-guard:Rediger …→Edit …,Redigerer: …→Editing: …,Annuller→Cancel,Bekræft→Confirm,Færdig med redigering af …→Done editing ….manual-face-bbox:Træk for at markere ansigtet→Drag to draw a face box,Træk for at flytte→Drag to move.plant-marker-move,plant-assignment:Rediger plants_image→Edit plants_image,Redigerer: plants image→Editing: plants image,Bekræft→Confirm.timeline:Tildeling fjernet.→Assignment removed..discovery-instance-tentative,instance-split-move(fallout found in the break-candidate run): hardcoded Danish aria3 tentative tildelinger→3 tentative assignments.Locale-pinned expectation (da-pinned test block):
discovery-instance-tentativeassignment history (da copy pinned)asserts the Danish viewer ariaMediedetaljefremviser(the section label was hardcoded English before extraction).Verification
npm run check— 0 errors (18 warnings, pre-existing).npm run build— exit 0.npm run test:unit— 26 files / 200 tests passed.main(all 15 wave-scoped specs matchingmap|people|person|share|upload|viewer|timeline|marker|info-panelplus 20+ off-list break candidates: accessibility, media-metadata-edit, on-this-day, scope-crop, discovery-media-list, discovery-instance-tentative, instance-split-move, instance-remove-mode, instance-detail-face-crop, discovery-review, albums, discovery-domain-*, filter-sort, spec-013, explore-titles-first, incomplete-media, search-overlay/filters/backfill, thumbnails, storage-paths, header-avatar): 925 passed, 4 flaky (all passed on retry), 23 pre-existing conditional skips, 0 deterministic failures.upload-statushydration/timing races →KNOWN_ISSUESISSUE-072;embedding-map:463+discovery-domain-instance-detail+accessibility:128load races → ISSUE-148/149 class (isolated reruns pass).Deferrals
Recorded in
EXTRACTION.mdwave-3 row:EmbeddingMap.svelte,ShareInstanceDialog.svelte,ActivityDialog.svelte,NotificationBell.svelte(shared components outside the wave-3 route/component scope).ContributionPanel.sveltewas in scope and is extracted here.Reviewer notes
viewerDialogAria(daMediedetaljefremviser),mediaDomainToggleAria(daSkjul/vis {label}-markører), themediaReset*Doneplural variants, and thepersonPicker*Danish copy.mediaMarkerCreatedToast,personPicker*,mediaAssignmentRemovedToast).sharingRulesWarningEN intentionally begins lowercase (follows<strong>{m.sharingModeRules()}</strong>in markup).ActivityDialogkeep byte-identical English (2 file(s) ready to upload.,1 uploaded · 0 skipped · 1 failed).