fix(web): resolve 24 pre-existing main E2E failures (not i18n regressions) #1182
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/main-e2e-preexisting-failures"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Why
CI run 4506 (job 55974) on
mainshowed 24 failed + 6 flaky E2E tests. All 24 reproduce on an unmodifiedmaincheckout (38f56115) with no i18n work in the tree — they are pre-existing main failures, not regressions from the Paraglide wave-1 i18n PR (#1178). This PR fixes them.Root causes (per failure group)
manual-face-bbox(desktop+mobile, also the CI flake)transition:fadeon an in-flowmin-h-screendiv, so during the 300 ms outro the skeleton and the loaded viewer coexisted in flow and the image surface jumped ~407 px. Pointer coords for a bbox drawn during that window were normalized against the post-jump rect → persistedy0.806 instead of 0.2 (data corruption for a real user, not just a test artifact). Measured: surface top 521 → 114 px. Fixed by making the outgoing skeleton anabsolute inset-0 pointer-events-noneoverlay. Coordinate math inFaceMarker*/mediaUtilsverified correct — untouched.discovery-domain-instance-detail×5 (both projects)domainLabels.singularLabelsince75621b6c("Plant - Rose", "Plant", …); back link now renders the intentionally capitalized plural (Plantsvs the old lowercaseddomainKey-derivedplants). Test expectations updated.DiscoveryInstanceDetail.svelteandDomainSuggestionsCarousel.svelteuntouched.library-stats:60Intl.NumberFormat(getLocale())resolves to English base locale →12,345vs expected12.345. Pinnedlocale=dacookie to preserve the spec's intent.profile-tabs×4 (both projects)profileTab*messages (Konto, …) while page headings stay hardcoded English. Pinnedlocale=da.storage-paths×2 (both projects)Speicherpfade einrichten,Wartung) is localized; with no cookie the app rendered English. Pinnedlocale=de.Additionally fixed the
timeline:2171mobile flake:getByRole('button', { name: 'Add' })substring-matchesClose add to album, so while the album list was still loading.last()resolved to the close button — dialog dismissed, no toast. Now requires the exact name.Not fixed (tracked)
backup-export:5and ISSUE-149 discovery merge menu flake: load-dependent click-swallow races that pass on retry; need a load repro first.Verification (all from this worktree)
npx playwright test: 995 passed, 23 skipped, 0 failed, 0 flaky (exit 0)npm run check: 0 errors (18 pre-existing warnings, unchanged)manual-face-bboxextra soak: 30/30 consecutive passes after the timeline fix